Skip to content

fix #1416 - ClassNotFound for FlowParameters #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dimipaun
Copy link
Contributor

Fix for #1416
See https://stackoverflow.com/a/28589962/4548500 for details.

Hey there! So you want to contribute to FirebaseUI? Before you file this pull request, follow these steps:

  • Read the contribution guidelines.
  • Run ./gradlew check to ensure the Travis build passes.
  • If this has been discussed in an issue, make sure to mention the issue number here. If not, go file an issue about this to make sure this is a desirable change.
  • If this is a new feature please co-ordinate with someone on FirebaseUI-iOS to make sure that we can implement this on both platforms and maintain feature parity.

@dimipaun dimipaun requested a review from samtstern as a code owner September 18, 2018 21:49
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@dimipaun
Copy link
Contributor Author

I signed it.

@googlebot
Copy link

CLAs look good, thanks!

@samtstern samtstern added this to the 4.2.1 milestone Sep 18, 2018
@samtstern samtstern changed the base branch from master to version-4.2.1-dev September 18, 2018 21:58
@samtstern samtstern merged commit 0786884 into firebase:version-4.2.1-dev Sep 18, 2018
@samtstern
Copy link
Contributor

@dimipaun thanks for this! This will be in version 4.2.1 (or whatever version comes out next, might be 4.3.0)

@dimipaun
Copy link
Contributor Author

It's all @SUPERCILEX , I just followed his lead!
I can't wait to give this a try, hopefully next release will be out soon.
As a side note, I can't believe we're the only people that have this issue.
How can this be? What am I missing?

@dimipaun dimipaun deleted the fix-for-flow-params-class-not-found branch September 19, 2018 16:55
@samtstern
Copy link
Contributor

@dimipaun I have no idea why you're seeing this issue, or why others are not.

You can try this right now using the 4.2.1-SNAPSHOT builds if you just want to verify (see the main README for instructions).

samtstern added a commit that referenced this pull request Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants